Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add component CSVDocumentCleaner for removing empty rows and columns #8816

Merged
merged 9 commits into from
Feb 6, 2025
Merged

feat: Add component CSVDocumentCleaner for removing empty rows and columns #8816

merged 9 commits into from
Feb 6, 2025

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 5, 2025 •
edited
Loading

Related Issues

Proposed Changes:

Adds a new component called CSVDocumentCleaner.

This component is for cleaning CSV documents by removing empty rows and columns. Removing empty rows and columns can help reduce unnecessary token usage when sending this CSV document to an LLM in a RAG pipeline.

It allows for the optional ignoring of a specified number of rows and columns before performing the cleaning operation. This is relevant if you want to ignore header rows or columns (e.g. the header of an Excel file) before removing empty rows or columns.

How did you test it?

Added tests.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested review from a team as code owners February 5, 2025 12:15
@sjrl sjrl requested review from dfokina and vblagoje and removed request for a team February 5, 2025 12:15
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Feb 5, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13183433551

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 92.653%
Totals Coverage Status
Change from base Build 13183321618: -0.007%
Covered Lines: 9030
Relevant Lines: 9746
💛 - Coveralls

@sjrl sjrl requested a review from davidsbatista February 6, 2025 16:33
davidsbatista
davidsbatista approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjrl sjrl merged commit 1785ea6 into main Feb 6, 2025
19 checks passed
@sjrl sjrl deleted the csv-cleaner branch February 6, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a CSV Document cleaner component
3 participants
@sjrl @coveralls @davidsbatista